Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sozu: 0.11.46 -> 0.11.50; fix Darwin build #100290

Merged
merged 1 commit into from Nov 2, 2020
Merged

sozu: 0.11.46 -> 0.11.50; fix Darwin build #100290

merged 1 commit into from Nov 2, 2020

Conversation

happysalada
Copy link
Contributor

Motivation for this change

build was broken on darwin

Things done
  • I ran nixfmt, so formatting has changed a bit
  • As opposed to the last similar PR, I didn't alias Security from apple_sdk, so this PR should pass the build
  • upgraded sozu from 0.11.46 -> 0.11.50
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 12, 2020
@happysalada
Copy link
Contributor Author

@Br1ght0ne Last PR had an alias that wasn't propagated to all-packages.nix, this one should pass.

@happysalada
Copy link
Contributor Author

@sikmir not sure, who to ask to get this merged

@sikmir sikmir requested a review from Br1ght0ne October 23, 2020 12:07
@happysalada
Copy link
Contributor Author

@danieldk When you have a moment.

danieldk
danieldk suggested changes Nov 1, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit messages must follow the format in CONTRIBUTING.md. Though, in this case it's probably enough to squash the commits in a single commit with the message

sozu: 0.11.46 -> 0.11.50; fix Darwin build

@happysalada
Copy link
Contributor Author

@danieldk Thanks for having a look at it so quickly!

danieldk
danieldk approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 100290 1

1 package built:
  • sozu

@danieldk danieldk merged commit b31e052 into NixOS:master Nov 2, 2020
@happysalada happysalada deleted the sozu branch April 28, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@sikmir sikmir sikmir approved these changes

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@happysalada @danieldk @sikmir