python3Packages.rich: init at 8.0.0 #100273
Conversation
|
|
||
| propagatedBuildInputs = [ typing-extensions pygments recommonmark colorama ]; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
If the pypi package does not contain the tests please switch to the GitHub sources.
There was a problem hiding this comment.
Switched to GitHub sources. I had to patch setup.py though, see 9651c26.
| buildPythonPackage rec { | ||
| pname = "rich"; | ||
| version = "8.0.0"; | ||
| disabled = isPy27; |
There was a problem hiding this comment.
The difference is probably minimal, but pythonOlder "3.6" is probably more accurate? https://github.com/willmcgugan/rich/blob/master/pyproject.toml#L26
- Use fetchFromGitHub, needed for enabling tests - Use pythonOlder to match exact requirement of the package
| }; | ||
|
|
||
| postPatch = '' | ||
| sed -i 's/setuptools.setup(name="rich")/setuptools.setup(name="rich", packages=setuptools.find_packages())/g' setup.py |
|
|
||
| propagatedBuildInputs = [ typing-extensions pygments recommonmark colorama ]; | ||
|
|
||
| checkInputs = [ pytest pytestcov ]; |
There was a problem hiding this comment.
We generally don't require coverage tests, since they are of no use to us. If you can skip them easily that would be appreciated.
There was a problem hiding this comment.
seeing as the test suite is invoked through "make test", it may be required there.
However, it would probably be best to look at the command that make test is running, and just run it without coverage plugins.
There was a problem hiding this comment.
Thanks for the feedback. This is the command called: pytest --cov-report term-missing --cov=rich tests/ -vv. I guess the -vv can be omitted as well? I'll update the PR.
|
I guess that was bad timing and we can close this PR: 5b66067 |
Motivation for this change
Dependency for latest version of ansible-lint
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)I could run the unit tests when using
fetchFromGitHubinstead offetchPypibut thenpythonImportsCheckfailed. I sticked tofetchPypifor now and disabled the unit tests.