Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ngscopeclient/scopehal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 004e30c708ee
Choose a base ref
...
head repository: ngscopeclient/scopehal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1e73de90fe06
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 12, 2020

  1. Copy the full SHA
    1e73de9 View commit details
Showing with 2 additions and 2 deletions.
  1. +2 −2 scopehal/SCPITransport.h
4 changes: 2 additions & 2 deletions scopehal/SCPITransport.h
Original file line number Diff line number Diff line change
@@ -57,7 +57,7 @@ class SCPITransport
virtual bool IsConnected() =0;

public:
typedef SCPITransport* (*CreateProcType)(std::string args);
typedef SCPITransport* (*CreateProcType)(const std::string& args);
static void DoAddTransportClass(std::string name, CreateProcType proc);

static void EnumTransports(std::vector<std::string>& names);
@@ -70,7 +70,7 @@ class SCPITransport
};

#define TRANSPORT_INITPROC(T) \
static SCPITransport* CreateInstance(std::string args) \
static SCPITransport* CreateInstance(const std::string& args) \
{ \
return new T(args); \
} \