cargo-edit: fix Darwin build #100289
cargo-edit: fix Darwin build #100289
Conversation
| buildInputs = [ openssl ] ++ lib.optionals stdenv.isDarwin [ libiconv darwin.apple_sdk.frameworks.Security ]; | ||
| nativeBuildInputs = [ | ||
| pkg-config | ||
| xcbuild # the cc crate attempts to run xcbuild |
There was a problem hiding this comment.
This should not be necessary once staging is merged in master:
Maybe add a reference + comment that this should be removed once that PR lands?
Also, the xcbuild dependency should (probably) be conditional so that's only used on Darwin.
There was a problem hiding this comment.
pushed a fix, let me know if that works for you.
There was a problem hiding this comment.
Thanks! I have pushed a change that makes the formatting a little more canonical. While at it, I tacked on another commit that passes the Security framework in the preferred manner.
There was a problem hiding this comment.
Thanks!
I didn't know that was the prefered manner. Will keep it in mind for next time.
| description = | ||
| "A utility for managing cargo dependencies from the command line"; | ||
| homepage = "https://github.com/killercup/cargo-edit"; | ||
| license = with licenses; [ asl20 /* or */ mit ]; | ||
| license = with licenses; [ | ||
| asl20 # or | ||
| mit | ||
| ]; |
There was a problem hiding this comment.
Are these changes necessary? Did nixpkgs-fmt make them?
There was a problem hiding this comment.
yes, I just ran the formatter.
There was a problem hiding this comment.
Strange, I don't get that formatting with nixpkgs-fmt.
Motivation for this change
Latest version was not building on darwin
Things done
Originally my intent was only to change things on darwin platform.
It appears though that libz was missing as a dependency.
Also in a lot of recent rust builds, cc crate attempts to run xcbuild.
I also run nixfmt, so some format has changed a little bit.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)