Skip to content

picom: 8.1 -> 8.2 #103045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2020
Merged

picom: 8.1 -> 8.2 #103045

merged 1 commit into from
Nov 7, 2020
+2 −2

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Nov 6, 2020 •
edited
Loading

Motivation for this change

https://github.com/yshui/picom/releases/tag/v8.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested a review from Enzime November 6, 2020 22:54
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 6, 2020
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 6, 2020 •
edited
Loading

Result of nixpkgs-review pr 103045 run on x86_64-linux 1

1 package failed to build:
  • picom (compton)
  Found ninja-1.10.1 at /nix/store/lm4rgsn0bl1pd6p31ibzz20y046clcma-ninja-1.10.1/bin/ninja
  Using 'STRIP' from environment with value: 'strip'
  Using 'STRIP' from environment with value: 'strip'
  meson: enabled parallel building
  building
  build flags: -j8 -l8
  [0/28] Compiling C object src/picom.p/picom.c.oninja: fatal: posix_spawn: No such file or directory
cannot build derivation '/nix/store/21fybzvrwzc7jdvyclv00vsfyhf0rn70-env.drv': 1 dependencies couldn't be built

@teto
Copy link
Member

teto commented Nov 7, 2020

it builds for me and on the CI ? (x86_64-linux too)

@teto teto merged commit 4fcf71f into NixOS:master Nov 7, 2020
@thiagokokada thiagokokada deleted the bump-picom branch November 7, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enzime Enzime

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thiagokokada @SuperSandro2000 @teto