Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remarkable2-toolchain: init at 2.5.2 #103030

Merged
merged 1 commit into from Jan 14, 2021
Merged

remarkable2-toolchain: init at 2.5.2 #103030

merged 1 commit into from Jan 14, 2021

Conversation

tadfisher
Copy link
Contributor

Motivation for this change

Add the SDK for the reMarkable 2 tablet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

lukegb
lukegb approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@lukegb lukegb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: This... installed something.

I suspect, however, you probably want to fix the fixup phase, because I'm concerned it's doing weird things to the target sysroot.

But... this is the same as what the remarkable 1 toolchain does, so LGTM.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103030 run on x86_64-linux 1

1 package built:
  • remarkable2-toolchain
`gpl2` is a deprecated license, check if project uses `gpl2Plus` or `gpl2Only` and change `meta.license` accordingly.

@SuperSandro2000 SuperSandro2000 merged commit 7cb3bff into NixOS:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@lukegb lukegb lukegb approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tadfisher @SuperSandro2000 @lukegb