Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pylance: init at 220.11.0 #103025

Closed
wants to merge 1 commit into from
Closed

pylance: init at 220.11.0 #103025

wants to merge 1 commit into from

Conversation

scalavision
Copy link
Contributor

Motivation for this change

pylance is the new Python language server by Microsoft for vscode. Probably very useful for a
lot of developers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [x ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [x ] Ensured that relevant documentation is up to date
  • [x ] Fits CONTRIBUTING.md.

@scalavision
Copy link
Contributor Author

scalavision commented Nov 6, 2020 •
edited

I didn't find an easy way of testing this package, basically I added it to my global configuration.nix and built the system pointing vscode's nixpkgs to this branch. Basically using this hack:

Running vscode, the plugin seems to be picked up and everything seems magically to work :-)

SuperSandro2000
SuperSandro2000 reviewed Nov 24, 2020
View reviewed changes
pkgs/misc/vscode-extensions/default.nix Outdated
Comment on lines 170 to 171
};

};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
};
};
};
};

@SuperSandro2000
Copy link
Member

Can you please resolve the merge conflict?

@scalavision
Copy link
Contributor Author

Did this work? I thought this already was merged, so I had started to make changes locally for personal use. Let me know if there are any other changes needed to be done.

@scalavision scalavision mentioned this pull request Dec 1, 2020
Merged
4 tasks
@scalavision
Copy link
Contributor Author

@SuperSandro2000 I created another PR to resolve the merge conflict in an easy way:

#105601

@SuperSandro2000
Copy link
Member

Closing in favor of #105601

@SuperSandro2000
Copy link
Member

@SuperSandro2000 I created another PR to resolve the merge conflict in an easy way:

#105601

The easy way it to rebase the one commit on master and force pushing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@teto teto teto approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scalavision @SuperSandro2000 @teto