bintools-wrapper: remove redundant arg #103053
Conversation
cctools 949.0.1 warns if min version is passed twice.
This reverts commit d73cc1e.
|
I think #101602 can now be reverted as well |
Yeah, I'll do that after this lands in master so it doesn't interfere the workflow on the |
ofborg
bot
added
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 0
labels
There was a problem hiding this comment.
Rebuilt stdenv + affected packages a couple weeks ago, worked for me #101330 (comment)
There was a problem hiding this comment.
Sorry I'm late. LGTM, thanks!.
Reading the git history about this flag, seem to be okay to remove it:
The -macosx_version_min flag isn't strictly necessary since that's already handled by MACOSX_DEPLOYMENT_TARGET.
a826b49
the compiler always adds the flag [
-macos_version_min] based on the variable [MACOSX_DEPLOYMENT_TARGET], overriding this original one, it's not really necessary. Added it just in case but should be fine to leave out if you're concerned about it. #77632 (comment)
|
I think this broke |
|
Verified reverting this fixes both bazel and libmodplug, which are currently broken on master. It's possible other packages are affected too. |
|
I have created #105573 to track this down. |
Motivation for this change
Fix #101330
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)