Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cerebral-debugger: init at 3.1.0 #103027

Closed
wants to merge 1 commit into from
Closed

cerebral-debugger: init at 3.1.0 #103027

wants to merge 1 commit into from

Conversation

scalavision
Copy link
Contributor

@scalavision scalavision commented Nov 6, 2020 •
edited

Motivation for this change

Cerebral is a javascript library that you might have to deal with if you are a front-end javascript developer. Making
it work in NixOS was not straight forward, since it uses electron under the hood, so it would be rather nice
having it already in nixpkgs.

Things done
  • [x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [x ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [x ] Ensured that relevant documentation is up to date
  • [x ] Fits CONTRIBUTING.md.

some CAVEATS:

  • The app.asar binary is used directly, hence this is not built from source
  • The cerebral is upgraded to electron 4, this version still have security issues

I have notified the author of the library about the security issues, using version 4 of electron instead of version 1 seems not affecting the app. I have used it quite a lot without any problems.

I would be happy to build this completely from source, but would need some guidance, as I have no experience with electron apps and very little experience using node on nixpkgs.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103027 run on x86_64-linux 1

1 package marked as broken and skipped:
  • cerebral-debugger

@scalavision
Copy link
Contributor Author

scalavision commented Nov 7, 2020 •
edited

Thanks @SuperSandro2000 . I have fixed the things you commented I believe :-)

Hm.. I am not sure what is meant with the 1 package marked as broken and skipped part. The problem is that electron 4 is broken due to security issues. To enable it, you have to do this in ~/.config/nixpkgs/config.nix :

{
   permittedInsecurePackages = [
     "electron-4.2.12"
   ];
}

This is of course very unfortunate, but dealing with more or less legacy software often is ..

There is also an error reported: dev-app-update.yaml found ..

This does not seem to affect the use of the tool. I think it is something electron provides, that I am not sure would work in nixpkgs anyways ..

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103027 run on x86_64-linux 1

1 package marked as broken and skipped:
  • cerebral-debugger

@SuperSandro2000
Copy link
Member

Hm.. I am not sure what is meant with the 1 package marked as broken and skipped part.

Probably the marked insecure part.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103027 run on x86_64-linux 1

1 package built:
  • cerebral-debugger

@SuperSandro2000
Copy link
Member

I don't like the idea of adding something that relies on something marked insecure. I think NUR could be a place for this but for nixpkgs it is to old. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scalavision @SuperSandro2000