Kicad: 5.1.6 -> 5.1.8 #103051
Merged
Kicad: 5.1.6 -> 5.1.8 #103051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it will now correctly build a version.nix file from scratch
patch for issue 72248 no longer applies issue doesn't seem to occur without it anymore...
|
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
|
@berce is inactive and kiwi is more of a concerned party than a maintainer |
bjornfor
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes and closes #99201
Motivation for this change
a new release
Things done
fix update.sh to be able to generate versions.nix from scratch again
update all versions to the latest revision
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS linux)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"Tested execution of all binary files (usually in
./result/bin/)Determined the impact on package closure size (by running
nix path-info -Sbefore and after)/nix/store/bszi8bh2nyaw1njljihxj46ywps46zc4-kicad-5.1.6 6662184496/nix/store/5ncgzbr4szv9c7rfy75wcxyvp8nwj01b-kicad-5.1.8 6786043024Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.
/marvin opt-in
/status needs_reviewer