Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssmsh: init at 1.4.3 #103052

Merged
merged 2 commits into from Nov 12, 2020
Merged

ssmsh: init at 1.4.3 #103052

merged 2 commits into from Nov 12, 2020

Conversation

dbirks
Copy link
Member

@dbirks dbirks commented Nov 7, 2020

Motivation for this change

Adding a tool that I started using recently. It allows you to browse and edit AWS Parameter Store, kind of in the same way as you would move around in a filesystem (with cd, ls, mv, rm). I've found it quite handy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit November 7, 2020 04:57
SuperSandro2000
SuperSandro2000 reviewed Nov 7, 2020
View reviewed changes
pkgs/tools/admin/ssmsh/default.nix Outdated
pname = "ssmsh";
version = "1.4.3";

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchFromGitHub can be used here right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the simplicity of fetchurl, but yes you're right, it looks like most of the Go packages use fetchFromGithub, so I'll switch over to that...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok switched over 👍

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103052 run on x86_64-linux 1

1 package built:
  • ssmsh

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103052 run on x86_64-darwin 1

1 package built:
  • ssmsh

@dbirks
Copy link
Member Author

dbirks commented Nov 9, 2020

Thanks for testing it on both Linux and MacOS 👍

@Lassulus Lassulus merged commit 40811ee into NixOS:master Nov 12, 2020
@dbirks dbirks deleted the add-ssmsh branch November 12, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbirks @SuperSandro2000 @Lassulus