Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.mirage-block: init at 2.0.1 #101825

Merged
merged 2 commits into from Oct 27, 2020
Merged

ocamlPackages.mirage-block: init at 2.0.1 #101825

merged 2 commits into from Oct 27, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 27, 2020

Motivation for this change

#23955

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Oct 27, 2020
View reviewed changes
pkgs/development/ocaml-modules/mirage-block/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/mirage-block/default.nix
sha256 = "1wp8wmixaz9i2sbvq6nkx903lbnpdgb2w404pz1wk8kcg9p3ilcc";
};

propagatedBuildInputs = [ cstruct lwt mirage-device ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are sure this are not only build dependencies?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I am.

SuperSandro2000
SuperSandro2000 reviewed Oct 27, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build on darwin:

Result of nixpkgs-review pr 101825 1

1 package built:
  • ocamlPackages.mirage-block

@vbgl
ocamlPackages.mirage-block: refactor meta attribute set
ca4e00c 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@cole-h
Copy link
Member

cole-h commented Oct 27, 2020

@ofborg eval

@ehmry ehmry merged commit ac97a9a into NixOS:master Oct 27, 2020
@vbgl vbgl deleted the ocaml-mirage-block-2.0.1 branch October 28, 2020 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbgl @cole-h @SuperSandro2000 @ehmry