New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maxima: various cleanups #101830
maxima: various cleanups #101830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those gratuitous whitespace changes make it pretty hard to figure out what you've actually changed. I'm not a fan of submissions reformatting the entire file to their personal taste.
Thank you for your reviews, @7c6f434c and @peti!
I am sorry to bother you. I will revise the patch to minimize whitespace changes. |
787c5e1
to
210149e
Compare
So, the formatting seems closer now. Would you point out if any of these patches are irrelevant to you? I will adopt subsequent patches. |
918b805
to
edbcc5d
Compare
Since packages are inherited by default, `package ? null` does not work as a declaration of optional dependency. To solve the problem, I added `with*` flags and used them consistently. With this change, the closure size of `maxima` was shrunk from 275429480 bytes to 213117176 bytes (reduced by 22.6%), and that of `maxima-ecl` was done from 383156392 bytes to 326807728 bytes (reduced by 14.5%). Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
This makes `patches` easier to read. Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
edbcc5d
to
16d1ffa
Compare
So, I will rework this and Maxima update to make them acceptable. I appologize for my hasty action. |
Motivation for this change
I have done some groundwork to ease not-yet-published update to Maxima 5.44.0. I published these cleanups separate from the update itself to make reviews easier.
I am still new to Nix so while I did my best some changes might not be idiomatic. Any suggestions are welcome!
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)