Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looking-glass-client: B1 -> B2 #101820

Merged
merged 1 commit into from Nov 9, 2020
Merged

Conversation

Chiiruno
Copy link
Contributor

Motivation for this change

Update looking glass.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@alexbakker alexbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Chiiruno
Copy link
Contributor Author

Chiiruno commented Nov 6, 2020

cc @Mic92
Not sure how things are done these days, but could we get this merged please?

@ofborg ofborg bot requested a review from alexbakker November 7, 2020 08:55
@Mic92 Mic92 merged commit feeda77 into NixOS:master Nov 9, 2020
@Chiiruno Chiiruno deleted the dev/looking-glass branch November 12, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants