Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teleprompter: 2.3.4 -> 2.4.0 #101844

Merged
merged 1 commit into from Oct 28, 2020
Merged

teleprompter: 2.3.4 -> 2.4.0 #101844

merged 1 commit into from Oct 28, 2020

Conversation

Scriptkiddi
Copy link
Contributor

@Scriptkiddi Scriptkiddi commented Oct 27, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Scriptkiddi Scriptkiddi marked this pull request as draft October 27, 2020 11:58
@Scriptkiddi Scriptkiddi marked this pull request as ready for review October 27, 2020 17:19
@sikmir
Copy link
Member

sikmir commented Oct 27, 2020

Please, update license to gpl3Plus according to
https://github.com/ImaginarySense/Imaginary-Teleprompter/blob/3a11d747493837e722a9e5a6bf9dc72fe1b936e3/package.json#L6

mweinelt
mweinelt reviewed Oct 28, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also work against a more recent electron version?

error: Package ‘electron-4.2.12’ in /home/hexa/git/nixos/master/pkgs/development/tools/electron/generic.nix:8 is marked as insecure, refusing to evaluate.


Known issues:
 - Electron version 4.2.12 is EOL

@Scriptkiddi
Copy link
Contributor Author

@mweinelt done

@mweinelt
Copy link
Member

Result of nixpkgs-review pr 101844 1

1 package built:
  • teleprompter

@mweinelt mweinelt merged commit 2755df8 into NixOS:master Oct 28, 2020
@ajs124 ajs124 deleted the telepromter-2.4.0 branch November 8, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 left review comments

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Scriptkiddi @sikmir @mweinelt @ajs124