Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.21.2 -> 1.22.0 #101853

Merged
merged 2 commits into from Oct 28, 2020
Merged

matrix-synapse: 1.21.2 -> 1.22.0 #101853

merged 2 commits into from Oct 28, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 27, 2020

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v1.22.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 27, 2020
@ofborg ofborg bot requested a review from pacien October 27, 2020 14:03
SuperSandro2000
SuperSandro2000 approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on darwin with #101319 merged.

@mweinelt
Copy link
Member

Result of nixpkgs-review pr 101853 1

1 package built:
  • matrix-synapse

Ekleog
Ekleog approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had a comment about potential improvements for the optional dependency but IMO this is good enough to land as is if you don't feel like doing it now

pkgs/servers/matrix-synapse/default.nix Outdated Show resolved Hide resolved
@Ma27
matrix-synapse: make dependency for hiredis optional
ff94877 
This is only needed for replication which isn't even supported by the
current NixOS module.
@Ma27 Ma27 requested review from Ekleog and mweinelt October 28, 2020 20:09
@ofborg ofborg bot requested a review from fadenb October 28, 2020 20:17
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 101853 1

1 package built:
  • matrix-synapse

@mweinelt mweinelt merged commit 41f0c4a into NixOS:master Oct 28, 2020
@Ma27 Ma27 deleted the bump-matrix-synapse branch October 28, 2020 21:05
@Ma27
Copy link
Member Author

Ma27 commented Oct 28, 2020

@mweinelt do you also take care of the backport? %)

@mweinelt
Copy link
Member

Feel free to do it, I'm busy with #101968 right now.

@Ma27
Copy link
Member Author

Ma27 commented Oct 28, 2020

20.03: e39c1f4, 504f993
20.09: bf86311, 86777b5

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadenb fadenb fadenb approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@Ralith Ralith Awaiting requested review from Ralith

@mguentner mguentner Awaiting requested review from mguentner

@ajs124 ajs124 Awaiting requested review from ajs124

@pacien pacien Awaiting requested review from pacien

@Ekleog Ekleog Awaiting requested review from Ekleog

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Ma27 @mweinelt @Ekleog @fadenb @SuperSandro2000 @worldofpeace