Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/searx: declarative configuration #101849

Merged
merged 7 commits into from Jan 11, 2021
Merged

nixos/searx: declarative configuration #101849

merged 7 commits into from Jan 11, 2021

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 27, 2020 •
edited

Motivation for this change

The pain of having to manually diff the settings.yml on every update,
like if NixOS were some kind of Arch Linux.

Things done
  • Tested environment substitution
  • Tested configuration merging
  • Tested service runs
  • Remove searx uid,gids
  • Document changes in the release notes
  • Run more tests for uWSGI
  • Figure out why immediate-uid is necessary
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj force-pushed the searx branch 2 times, most recently from cedecca to 7b58eb4 Compare November 2, 2020 00:38
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 2, 2020

I managed to get the right merging behavior by making engines an attrset and casting some jq spells.
Also added a test and documentation.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 7, 2020 •
edited

I went down a rabbit hole trying to run searx in uWSGI but I finally did it.
This is a must because searx runs in werkzeug by default: it logs every request (including search keywords!) and there is no way to disable logging unless one changes the webserver, of course.

@rnhmjoj rnhmjoj requested a review from LnL7 November 7, 2020 01:48
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 7, 2020

The PR got so big, maybe uWSGI changes should be split out.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 13, 2020

Fixed a couple more issues with uWSGI.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 6, 2020 •
edited

For easier review, I've opened a PR with only the uwsgi changes: #106082

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jan 10, 2021

Rebased. Now that the uWSGI changes have been accepted this builds in master.

@rnhmjoj rnhmjoj merged commit b1fb65a into NixOS:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@LnL7 LnL7 Awaiting requested review from LnL7

@schneefux schneefux Awaiting requested review from schneefux

@matejc matejc Awaiting requested review from matejc

@fpletz fpletz Awaiting requested review from fpletz

@abbradar abbradar Awaiting requested review from abbradar

@danielfullmer danielfullmer Awaiting requested review from danielfullmer

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @SuperSandro2000