Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snow: init at 20130616 #101831

Merged
merged 1 commit into from Nov 26, 2020
Merged

snow: init at 20130616 #101831

merged 1 commit into from Nov 26, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Oct 27, 2020

Motivation for this change

#81418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Oct 27, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not build for me:

builder for '/nix/store/jvc3648wyx7fpafk0dc12crzlm5zn4yz-snow-20130616.tar.gz.drv' failed with exit code 1; last 7 log lines:

  trying http://www.darkside.com.au/snow/snow-20130616.tar.gz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
  curl: (22) The requested URL returned error: 406 Not Acceptable
  error: cannot download snow-20130616.tar.gz from any mirror
cannot build derivation '/nix/store/f717a79a5wrzjqkpqbgpkw4sskq64cxy-snow-20130616.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/schca705lbk8ilc3lbbp8jlb60n1q4yr-env.drv': 1 dependencies couldn't be built
[0 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/schca705lbk8ilc3lbbp8jlb60n1q4yr-env.drv' failed

pkgs/tools/security/snow/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/snow/default.nix Outdated Show resolved Hide resolved
@siraben
Copy link
Member Author

siraben commented Oct 27, 2020

@SuperSandro2000 Is the URL http://www.darkside.com.au/snow/snow-20130616.tar.gz accessible for you?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 27, 2020 •
edited

@SuperSandro2000 Is the URL http://www.darkside.com.au/snow/snow-20130616.tar.gz accessible for you?

In my browser but not via curl:

curl http://www.darkside.com.au/snow/snow-20130616.tar.gz
<html><head><title>Error 406 - Not Acceptable</title><head><body><h1>Error 406 - Not Acceptable</h1><p>Generally a 406 error is caused because a request has been blocked by Mod Security. If you believe that your request has been blocked by mistake please contact the web site owner.</p></body></html>

Thank you mods security!

@siraben
Copy link
Member Author

siraben commented Oct 27, 2020

Looks like it builds on the CI, though.

@SuperSandro2000
Copy link
Member

I think we either need a mirror or should mark this package accordingly. Unfree? Not sure.

@siraben
Copy link
Member Author

siraben commented Oct 27, 2020

Package is unfree? It uses the Apache License.

@SuperSandro2000
Copy link
Member

Package is unfree? It uses the Apache License.

Not really but I can't download it except with my browser which makes this not ideal.

@siraben
Copy link
Member Author

siraben commented Oct 28, 2020

I could archive this on archive.org and have the URL point to that.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 28, 2020 •
edited

Run on darwin:

Result of nixpkgs-review pr 101831 1

1 package built:
  • snow

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101831 run on x86_64-linux 1

1 package built:
  • snow

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101831 run on x86_64-darwin 1

1 package built:
  • snow

1 similar comment
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101831 run on x86_64-darwin 1

1 package built:
  • snow

@SuperSandro2000 SuperSandro2000 merged commit 80da379 into NixOS:master Nov 26, 2020
@siraben siraben deleted the snow-init branch November 27, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siraben @SuperSandro2000 @sikmir