Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts should respect GDK_DPI_SCALE #257

Closed
whitequark opened this issue Oct 27, 2020 · 4 comments
Closed

Fonts should respect GDK_DPI_SCALE #257

whitequark opened this issue Oct 27, 2020 · 4 comments
Assignees
Labels
rendering Changes to display capabilities

Comments

@whitequark
Copy link
Contributor

You probably want to use gtkWindow.get_screen()->get_resolution(); for that.

azonenberg added a commit that referenced this issue Oct 27, 2020
…ses the right DPI. See #257. Still more work needed to scale sizes of UI elements appropriately.
@azonenberg azonenberg self-assigned this Oct 27, 2020
@azonenberg azonenberg added the rendering Changes to display capabilities label Oct 27, 2020
@azonenberg
Copy link
Collaborator

azonenberg commented Oct 27, 2020

@whitequark I think this is fixed, please confirm and close?

Note that toolbar icons are not currently scaled. See #131.

Sorry, something went wrong.

@whitequark
Copy link
Contributor Author

please confirm and close?

Cannot confirm, trigger still not movable at GDK_SCALE=2.

Sorry, something went wrong.

@azonenberg
Copy link
Collaborator

This issue is only for text displaying too small and not respecting DPI scaling. #255 is the ticket for mouse input not being correctly scaled, which is a separate bug.

If rendering is now appropriately scaled, even if input isn't working, this issue can be closed.

Sorry, something went wrong.

@azonenberg
Copy link
Collaborator

Confirmed fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rendering Changes to display capabilities
Projects
None yet
Development

No branches or pull requests

3 participants
@whitequark @azonenberg and others