Skip to content

ghc*: Increase build timeout to 1 day #103007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2020
Merged

ghc*: Increase build timeout to 1 day #103007

merged 1 commit into from
Nov 6, 2020
+6 −0

Conversation

roberth
Copy link
Member

@roberth roberth commented Nov 6, 2020 •
edited
Loading

The default of 10 hours is insufficient for some of the slower
platforms like macOS and aarch64.

Motivation for this change

Restarts aren't just occasional. NB this change only affects 20.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@roberth
ghc*: Increase build timeout to 1 day
f3e27c1 
The default of 10 hours is insufficient for some of the slower
platforms like macOS and aarch64.
@roberth roberth requested a review from cdepillabout as a code owner November 6, 2020 09:35
@ofborg ofborg bot added 6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 6, 2020
@roberth roberth merged commit 29e9aa2 into NixOS:staging-20.09 Nov 6, 2020
This was referenced Nov 6, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@roberth