Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc*: Increase build timeout to 1 day #103008

Merged
merged 2 commits into from Nov 6, 2020
Merged

ghc*: Increase build timeout to 1 day #103008

merged 2 commits into from Nov 6, 2020

Conversation

roberth
Copy link
Member

@roberth roberth commented Nov 6, 2020

Motivation for this change

The default of 10 hours is insufficient for some of the slower platforms like macOS and aarch64.
The timeout failures have been causing delays and waste of build agent time on staging-20.09, quite opposite of the intent of the timeout feature.

I've decided not to tune the timeout per system type, because I don't expect GHC to have this kind of problem, and if it does, it would normally be caught by the lack of build log output after two hours. The timeout is a last resort for builds/tests that loop while printing to the log. So decreasing the timeout for x86_64-linux would be over-engineered.

Things done

Applied this to staging-20.09 #103007 which should soon merge into release-20.09.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth
ghc*: Increase build timeout to 1 day
6057cb9 
The default of 10 hours is insufficient for some of the slower
platforms like macOS and aarch64.
cdepillabout
cdepillabout approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize this feature was available, but it sounds like this is a good idea for ghc.

@jonringer
Copy link
Contributor

should we run through a smaller subset of tests for those platforms?

@peti peti merged commit cd34bf3 into NixOS:master Nov 6, 2020
@roberth
Copy link
Member Author

roberth commented Nov 7, 2020

should we run through a smaller subset of tests for those platforms?

I don't think the time spent in tests is significant inside a ghc build.

@jonringer
Copy link
Contributor

Probably true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roberth @jonringer @cdepillabout @peti