Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] ungoogled-chromium: 85.0.4183.102-1 -> 86.0.4240.111-1 #103011

Closed
wants to merge 2 commits into from
Closed

[20.09] ungoogled-chromium: 85.0.4183.102-1 -> 86.0.4240.111-1 #103011

wants to merge 2 commits into from

Conversation

KamilaBorowska
Copy link
Member

Motivation for this change

It's very important to keep web browsers up-to-date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

gebner and others added 2 commits November 6, 2020 12:57
@gebner @KamilaBorowska
ungoogled-chromium: use jre8
f210f6e 
(cherry picked from commit 33bae62)
@KamilaBorowska
ungoogled-chromium: 85.0.4183.102-1 -> 86.0.4240.111-1
05cb5ed 
based on chromium master@26d3fbf2

(cherry picked from commit 744ea3d)
@KamilaBorowska KamilaBorowska changed the title [20.09] Backport ungoogled-chromium update [20.09] ungoogled-chromium: 85.0.4183.102-1 -> 86.0.4240.111-1 Nov 6, 2020
KamilaBorowska
KamilaBorowska commented Nov 6, 2020
View reviewed changes
pkgs/applications/networking/browsers/ungoogled-chromium/default.nix
@@ -162,13 +151,6 @@ let
''
else browser;

optionalVaapiFlags = if useVaapi # TODO: Remove after 20.09:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removal part of a commit that was cherry-picked, but I think it's fine considering ungoogled-chromium was never a part of NixOS 20.03, unlike chromium, so this error doesn't really serve a purpose.

@KamilaBorowska
Copy link
Member Author

Yeah, whatever, this doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KamilaBorowska @gebner