Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.asn1-combinators: 0.2.3 → 0.2.4 #103015

Merged
merged 2 commits into from Nov 6, 2020
Merged

ocamlPackages.asn1-combinators: 0.2.3 → 0.2.4 #103015

merged 2 commits into from Nov 6, 2020

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Nov 6, 2020 •
edited

Motivation for this change

OCaml 4.12 support

cc @vbgl

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build jackline dune-release

@vbgl
Copy link
Contributor

vbgl commented Nov 6, 2020

May you please set useDune2 = true? This will make it easier to later update cstruct.

@vbgl
Copy link
Contributor

vbgl commented Nov 6, 2020

@GrahamcOfBorg build dune-release jackline ocamlPackages.ocsigen-start ocamlPackages.prof_spacetime

@vbgl vbgl merged commit 255f45e into NixOS:master Nov 6, 2020
@sternenseemann sternenseemann deleted the ocaml-asn1-combinators-0.2.4 branch November 6, 2020 16:54
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103015 run on x86_64-darwin 1

1 package built:
  • jackline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sternenseemann @vbgl @SuperSandro2000