Add Chameleon96 #119
Merged
Add Chameleon96 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
reviewed
Nov 6, 2020
nmigen_boards/chameleon96.py
Outdated
| Subsignal("clk", Pins("AB20", dir="o")), | ||
| Subsignal("cmd", Pins("AB18", dir="io")), | ||
| Subsignal("data", Pins("Y14 AB19 AA18 AB15", dir="io")), | ||
| Attrs(io_standard="1.8 V"), |
There was a problem hiding this comment.
This is SDIO, right? Is there a reason to not use SDCardResources?
There was a problem hiding this comment.
Thanks for the hint. No, there's no reason, will change it.
kbeckmann
force-pushed
the
chameleon96
branch
from
ce0fb57
to
6acd934
Compare
whitequark
requested changes
Nov 6, 2020
kbeckmann
force-pushed
the
chameleon96
branch
from
6acd934
to
9daa227
Compare
whitequark
approved these changes
Nov 6, 2020
whitequark
approved these changes
Nov 24, 2020
|
Thanks for this excellent PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.