Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octoprint: add marlingcodedocumentation #103004

Merged

Conversation

lovesegfault
Copy link
Member

Motivation for this change

This adds the marlingcodevisualizer plugin to octoprint. I also did a drive-by
removal of references to a previously deprecated and removed plugin.

cc. @flokli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lovesegfault lovesegfault force-pushed the octoprint-marlingcodedocumentation branch from 53f4dbb to 1122d28 Compare November 6, 2020 19:48
@gebner
Copy link
Member

gebner commented Nov 8, 2020

Thanks!

@gebner gebner merged commit df88279 into NixOS:master Nov 8, 2020
@lovesegfault lovesegfault deleted the octoprint-marlingcodedocumentation branch November 9, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants