Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k9copy: remove for being broken since 2014 #103003

Merged
merged 1 commit into from Nov 6, 2020
Merged

k9copy: remove for being broken since 2014 #103003

merged 1 commit into from Nov 6, 2020

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

Problem is known at least since 2019: #63260 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

timstott
timstott approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@timstott timstott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little clean up always feels nice 🎩

@FRidh FRidh merged commit da04a8e into NixOS:master Nov 6, 2020
@freezeboy freezeboy deleted the remove-k9copy branch November 6, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timstott timstott timstott approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @timstott @FRidh