Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: 1.50.1 -> 1.51.0 #103013

Merged
merged 1 commit into from Nov 6, 2020
Merged

vscode: 1.50.1 -> 1.51.0 #103013

merged 1 commit into from Nov 6, 2020

Conversation

samuela
Copy link
Member

@samuela samuela commented Nov 6, 2020

Motivation for this change

Upgrades vscode from 1.50.1 to 1.51.0

This PR was automatically generated by nixpkgs-upkeep.

  • CI workflow that created this PR.
  • Internal tag: a85f8007e671d05f13a4c4d4ddb9c74d.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from eadwu and Synthetica9 November 6, 2020 12:26
jonringer
jonringer approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 103013 1

2 packages built:
  • vscode
  • vscode-with-extensions

@jonringer jonringer merged commit 55fc82d into NixOS:master Nov 6, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103013 run on x86_64-linux 1

2 packages built:
  • vscode
  • vscode-with-extensions

@samuela samuela deleted the upkeep-bot/vscode-1.51.0-1604664755 branch November 6, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@eadwu eadwu Awaiting requested review from eadwu

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuela @SuperSandro2000 @jonringer