Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zalgo: init at unstable-2020-08-26 #101428

Merged
merged 1 commit into from Dec 27, 2020
Merged

zalgo: init at unstable-2020-08-26 #101428

merged 1 commit into from Dec 27, 2020

Conversation

djanatyn
Copy link
Contributor

Motivation for this change

I need a way to generate text that looks haunted on NixOS this month.
T͕h̢̤̲í̙̞s t̡o̳̙o̳͢ļ̭̦̘ w̛̺il̞l s͖̗úf͓̮͜f̫̟͞i͉̟̠cẹ̩̱͝.

Z̛̼̩̤̲̘͜͞Ą̟͈̳̥̙ͅL̵͈̪̲̣̺̮G̢̪̞̦̱͖͓̳O̮̜̬̳̻̫͜͞.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@djanatyn
Copy link
Contributor Author

This is a new project that doesn't have a traditional version scheme (no semantic versioning). I'm not sure if using the git hash in the version attribute is appropriate?

IvarWithoutBones
IvarWithoutBones requested changes Oct 22, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor issues, otherwise LGTM 👍

pkgs/tools/misc/zalgo/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/zalgo/default.nix Outdated Show resolved Hide resolved
@djanatyn djanatyn force-pushed the pkg/zalgo branch 2 times, most recently from 8263d3f to d6856b0 Compare October 27, 2020 15:08
@djanatyn
Copy link
Contributor Author

Updated!

IvarWithoutBones
IvarWithoutBones requested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits should be squashed as well

Other than this, LGTM :)

pkgs/tools/misc/zalgo/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Can you please change the PR title and the commit message to:

zalgo: init at unstable-2020-08-26

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101428 run on x86_64-linux 1

1 package built:
  • zalgo

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101428 run on x86_64-darwin 1

1 package built:
  • zalgo

@djanatyn @SuperSandro2000
@sikmir @IvarWithoutBones
zalgo: init at unstable-2020-08-26
383bd9f 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Nikolay Korotkiy <sikmir@gmail.com>
Co-authored-by: Ivar <41924494+IvarWithoutBones@users.noreply.github.com>
@djanatyn
Copy link
Contributor Author

Can you please change the PR title and the commit message to:

zalgo: init at unstable-2020-08-26

Done, pushed 383bd9f.

@SuperSandro2000 SuperSandro2000 changed the title zalgo: init at 6aa1f66 zalgo: init at unstable-2020-08-26 Dec 27, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101428 run on x86_64-linux 1

1 package built:
  • zalgo

@SuperSandro2000 SuperSandro2000 merged commit 6c1c442 into NixOS:master Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@IvarWithoutBones IvarWithoutBones IvarWithoutBones requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@djanatyn @SuperSandro2000 @sikmir @IvarWithoutBones