Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildBazelPackage: build name from pname/version #101379

Merged
merged 1 commit into from Oct 28, 2020
Merged

buildBazelPackage: build name from pname/version #101379

merged 1 commit into from Oct 28, 2020

Conversation

teto
Copy link
Member

@teto teto commented Oct 22, 2020 •
edited

and updated bazel-remote accordingly.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
buildBazelPackage: build name from pname/version
6752ead 
and updated bazel-remote accordingly.
@teto teto requested a review from Profpatsch as a code owner October 22, 2020 13:45
@ofborg ofborg bot requested a review from uri-canva October 22, 2020 14:15
@uri-canva uri-canva removed their request for review October 23, 2020 05:45
Profpatsch
Profpatsch approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@teto teto merged commit 1f9ab74 into NixOS:master Oct 28, 2020
@teto teto deleted the bazel branch October 28, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Profpatsch approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @Profpatsch