Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pitivi: Fix .svg loading at startup, see #56943 #89691 #101398

Merged
merged 1 commit into from Oct 22, 2020
Merged

pitivi: Fix .svg loading at startup, see #56943 #89691 #101398

merged 1 commit into from Oct 22, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Oct 22, 2020

Motivation for this change

Pitivi crashes at startup, see:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Needs 20.09 backport.

@nh2 nh2 added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 22, 2020
@nh2 nh2 requested a review from jtojnar October 22, 2020 16:39
@nh2 nh2 self-assigned this Oct 22, 2020
This was referenced Oct 22, 2020
Closed
Merged
@jtojnar jtojnar merged commit 78ff7e0 into NixOS:master Oct 22, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Oct 22, 2020

Thanks.

@nh2 nh2 mentioned this pull request Oct 23, 2020
Merged
10 tasks
@nh2
Copy link
Contributor Author

nh2 commented Oct 23, 2020

20.09 backport at #101435

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees

@nh2 nh2

Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @jtojnar @erictapen