New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new meta-attributes to stdenv to permit URLs for screenshots #101417
Conversation
An alternative approach would be relying on the appstream data (#15932), cc @matthewbauer. |
Please squash the commits together. |
I can't take it from here. The other (#15932) issue is quite complex, involves many aspects. I cannot even identify all the different parts that are involved. |
@matthewbauer is there any timeline on #15932? That RFC is quite old, but I can see it is still in your radar. We could serve AppStream XML via search if you want. Would you be ok if @StefanSchroeder continues with this new meta-attributes? I'm assuming that we will be doing some merging of some sort when producing this XML. |
I marked this as stale due to inactivity. → More info |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/brainstorming-generating-appstream-metadata/19273/1 |
Motivation for this change
If a meta-attribute for a Screenshot-URL were added to the package description, the search result could include a screenshot of the application in the result. There is no need to create new screenshots as http://screenshots.debian.net/ provides a public repository of screenshots already that could be reused.
I am aware that adding screenshots to the existing thousands of packages would be a major undertaking, but I think it would be a nice user experience enhancement and - of course - optional, since screenshots only make sense for graphical applications.
When the Screenshot-URL is provided for a package, the search result could fetch the image and show it alongside the package description.
The font packages could show a sample of the font instead.
Things done
Two paragraphs were added to the Nixpks-manual, section Stdenv -> Meta-attributes to explain the two new
attributes ScreenshotThumb and ScreenshotLarge.
In the package games/pingus the two attributes were added as an example.
The Nixpkgs-manual was rebuild to check correctness.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)@garbas
Discussed in NixOS/nixos-search#211