Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

among-sus: init at 2020-10-22 #101384

Merged
merged 1 commit into from Oct 30, 2020
Merged

among-sus: init at 2020-10-22 #101384

merged 1 commit into from Oct 30, 2020

Conversation

eyJhb
Copy link
Member

@eyJhb eyJhb commented Oct 22, 2020

Not sure if this works on Mac OS X as well?
I see no reason why it sholudn't.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

IvarWithoutBones
IvarWithoutBones requested changes Oct 22, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions :)

pkgs/games/among-sus/default.nix Outdated Show resolved Hide resolved
pkgs/games/among-sus/default.nix Outdated Show resolved Hide resolved
IvarWithoutBones
IvarWithoutBones approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM, binary works 👍

Result of nixpkgs-review pr 101384 1

1 package built:
  • among-sus

@worldofpeace worldofpeace merged commit 8faab3d into NixOS:master Oct 30, 2020
@OPNA2608 OPNA2608 mentioned this pull request Jan 18, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@worldofpeace worldofpeace worldofpeace approved these changes

@IvarWithoutBones IvarWithoutBones IvarWithoutBones approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eyJhb @mweinelt @SuperSandro2000 @worldofpeace @IvarWithoutBones