Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.FutureAsyncAwait: 0.44 -> 0.45 #101402

Merged
merged 1 commit into from Oct 22, 2020

Conversation

zakame
Copy link
Member

@zakame zakame commented Oct 22, 2020

Motivation for this change

https://metacpan.org/release/PEVANS/Future-AsyncAwait-0.45

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp
Copy link
Member

stigtsp commented Oct 22, 2020

@GrahamcOfBorg build perlPackages.FutureAsyncAwait perldevelPackages.FutureAsyncAwait

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Result of nixpkgs-review pr 101402 1

2 packages built:
  • perl530Packages.FutureAsyncAwait
  • perl532Packages.FutureAsyncAwait

@stigtsp stigtsp merged commit 78a31ba into NixOS:master Oct 22, 2020
@zakame
Copy link
Member Author

zakame commented Oct 22, 2020

Thanks! 🎉

@zakame zakame deleted the updates/perl-FutureAsyncAwait-0.45 branch October 22, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants