nixos/dbus: re-add a dummy socketActivated option #101409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
reviewed
Oct 24, 2020
Comment on lines
73
to
74
| + " any effect. The user D-Bus session is now always socket activated" | ||
| + " and can safely be removed." |
There was a problem hiding this comment.
Nit:
Suggested change
| + " any effect. The user D-Bus session is now always socket activated" | |
| + " and can safely be removed." | |
| + " any effect and can be safely removed: the user D-Bus session is" | |
| + " now always socket activated." |
"is now always socket activated and can safely be removed" feels non-sequitur (the "safely be removed" does not apply to the "user D-Bus session", but instead to the option services.dbus.socketActivated).
If set, then issue a warning instead of an error as previously.
Since b08b0bc, the function actually causes an assertion error, not a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #101408. Also see #97801.