Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rambox: 0.7.6 -> 0.7.7 #100125

Merged
merged 1 commit into from Oct 10, 2020
Merged

rambox: 0.7.6 -> 0.7.7 #100125

merged 1 commit into from Oct 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 10, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Oct 10, 2020

cc @Ma27

@Ma27 Ma27 merged commit dda7212 into NixOS:master Oct 10, 2020
@ghost
Copy link
Author

ghost commented Oct 10, 2020

@Ma27 Thank you!

@ghost ghost deleted the rambox branch October 10, 2020 09:02
@Ma27
Copy link
Member

Ma27 commented Oct 10, 2020

Ported to 20.09 as ef619aa :)

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant