Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.dash-to-dock: 2020-04-20 -> 69 #100113

Merged
merged 1 commit into from Oct 10, 2020
Merged

gnomeExtensions.dash-to-dock: 2020-04-20 -> 69 #100113

merged 1 commit into from Oct 10, 2020

Conversation

worldofpeace
Copy link
Contributor

This version supports both 3.36 and 3.38.

Motivation for this change

The current version is a little buggy. Will backport after testing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
gnomeExtensions.dash-to-dock: 2020-04-20 -> 69
8cee2ba 
This version supports both 3.36 and 3.38.
@worldofpeace worldofpeace added this to In Progress in GNOME Oct 9, 2020
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: documentation labels Oct 9, 2020
@worldofpeace
Copy link
Contributor Author

Okay, running locally just fine.

@worldofpeace worldofpeace merged commit bf4866c into NixOS:master Oct 10, 2020
GNOME automation moved this from In Progress to Done Oct 10, 2020
@worldofpeace worldofpeace deleted the dash-to-dock-update branch October 10, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@emanueleperuffo emanueleperuffo Awaiting requested review from emanueleperuffo

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
GNOME
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace