Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pantheon fixups #100116

Merged
merged 4 commits into from Oct 12, 2020
Merged

Pantheon fixups #100116

merged 4 commits into from Oct 12, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

This is just stuff I noticed that was committed into #98316. I want to backport this to 20.09 so let's commit this to master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Because gnome-session now uses 'enabled' systemd session we have
to make this use --builtin [0]

[0]: elementary/session-settings@fa15cbd
These are now generated to be patched as a part of the elementary-session-settings
build.
@ofborg ofborg bot added 6.topic: pantheon The Pantheon desktop environment 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 6.topic: GNOME GNOME desktop environment and its underlying platform labels Oct 9, 2020
@worldofpeace worldofpeace added this to In progress in Pantheon via automation Oct 11, 2020
@ofborg ofborg bot removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label Oct 11, 2020
@worldofpeace worldofpeace merged commit 8cd159b into NixOS:master Oct 12, 2020
Pantheon automation moved this from In progress to Done Oct 12, 2020
@worldofpeace worldofpeace deleted the pantheon-stuff branch October 12, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pantheon
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant