New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linuxPackages.cpupower-gui: init at 1.0.0 #100120
Conversation
@jonringer as author of the original pull request, would you mind reviewing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main issue is we need to rewrite this to use buildPythonApplication
.
Though I do remember you mentioning a problem with wrapPython
on IRC, so maybe you already did this and found the pythonEnv
to be simpler. Let me know what you think.
4b1c563
to
2ff45e7
Compare
Thanks everyone for all the feedback. I think I included all the proposed changes. If there are no additional remarks, please merge when possible. |
52efad2
to
84e627b
Compare
ea3db02
to
d75e7e8
Compare
What you've done with |
Such a subtle difference. Was not aware that there is a distinction there. |
Updating this pull request since @vagnum08 released 0.9.0 in the meanwhile. |
Hi all, finally had the time to pick this up again but hit a bit a dependency bump in the road. I've updated the derivation and included the systemd definitions.
The master branch of nixpkgs includes a newer Due to the extra dependency, I'm still running cpupower-gui 0.9.1 which works fine in With that I'm thinking that it might make sense to push cpupower-gui 0.9.1 first to allow inclusion in |
We could just add a libhandy package to 20.09 like |
@worldofpeace would it make sense to backport In nixos-20.03 |
Hi everyone. Trying to push this forward there's now: #106680 which should allow us to have version cpupower-gui 1.0.0 in the tree. |
3a579bc
to
27aee71
Compare
I marked this as stale due to inactivity. → More info |
Is there any doc where I can read what might be wrong with the description field that is causing the manual build test to fail? |
Ok, I was using |
This has been ready for merge for a while, can someone review and do the final step? |
Have you tested the module? |
Yes, I've been using it since July without issues. Ah sorry, no I'm not familiar with those modules. |
sent it so you could test the module if you hadn't tested it yet |
Motivation for this change
This is round 2 of #94676 now including the necessary dbus / polkit modules for use as regular user.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)