Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cut-the-crap: 1.4.2 Mark unbroken #100107

Merged
merged 2 commits into from Oct 10, 2020
Merged

cut-the-crap: 1.4.2 Mark unbroken #100107

merged 2 commits into from Oct 10, 2020

Conversation

jappeace
Copy link
Contributor

@jappeace jappeace commented Oct 9, 2020

I fixed this upstream by adding c2hs to cabal as a built tool.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jappeace
cut-the-crap: Mark unbroken
ef2eaa9 
I fixed this by adding c2hs to cabal as a built tool.
@jappeace
Copy link
Contributor Author

jappeace commented Oct 9, 2020 •
edited

For version of cut-the-crap 2 I need to add youtube-dl to the overrides, so I'll come back to this.

@jappeace jappeace closed this Oct 9, 2020
@jappeace jappeace reopened this Oct 10, 2020
@jappeace
Copy link
Contributor Author

I realized that the version 2 changes should not affect the building, but I also added youtube-dl to the path which is harmless for version 1, but used if urls are provided instead of paths in version 2.

@cdepillabout
Copy link
Member

Looks good, thanks!

@cdepillabout cdepillabout merged commit f7e72e7 into NixOS:haskell-updates Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jappeace @cdepillabout