Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Package.gdcm: 3.0.7 -> 3.0.8 #100106

Merged
merged 1 commit into from Oct 10, 2020
Merged

python3Package.gdcm: 3.0.7 -> 3.0.8 #100106

merged 1 commit into from Oct 10, 2020

Conversation

tfmoraes
Copy link
Contributor

@tfmoraes tfmoraes commented Oct 9, 2020 •
edited

Motivation for this change

Update GDCM to 3.0.8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfmoraes
Copy link
Contributor Author

tfmoraes commented Oct 9, 2020 

❯ nix-shell -p nixpkgs-review --run "nixpkgs-review pr 100106"
these paths will be fetched (0.04 MiB download, 0.15 MiB unpacked):
  /nix/store/8ijmj6f8hiqxv1dr8f4i3ld4lnmcdwg9-nixpkgs-review-2.4.2
copying path '/nix/store/8ijmj6f8hiqxv1dr8f4i3ld4lnmcdwg9-nixpkgs-review-2.4.2' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/100106/head:refs/nixpkgs-review/1
remote: Enumerating objects: 17, done.
remote: Counting objects: 100% (17/17), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 18 (delta 14), reused 15 (delta 13), pack-reused 1
Unpacking objects: 100% (18/18), 2.22 KiB | 142.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   e782471d2b8..b863ef1e5f3  master                -> refs/nixpkgs-review/0
 + 51c14f8079b...d97be39275c refs/pull/100106/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/thiago/.cache/nixpkgs-review/pr-100106/nixpkgs b863ef1e5f398285eabec48b880129de5db2b38a
Preparing worktree (detached HEAD b863ef1e5f3)
HEAD is now at b863ef1e5f3 Merge pull request #100095 from worldofpeace/eval-fix
$ nix-env -f /home/thiago/.cache/nixpkgs-review/pr-100106/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit d97be39275cf0b60599f5cc6c02a914d61071aa7
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/thiago/.cache/nixpkgs-review/pr-100106/nixpkgs -qaP --xml --out-path --show-trace --meta
5 packages updated:
gdcm (3.0.7 → 3.0.8) python38Packages.gdcm (3.0.7 → 3.0.8) python37Packages.gdcm (3.0.7 → 3.0.8) python3.7-dicom2nifti python3.8-dicom2nifti

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/thiago/.cache/nixpkgs-review/pr-100106/build.nix
[4 built, 25 copied (340.5 MiB), 120.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/100106
5 packages built:
gdcm python37Packages.dicom2nifti python37Packages.gdcm python38Packages.dicom2nifti python38Packages.gdcm

$ nix-shell /home/thiago/.cache/nixpkgs-review/pr-100106/shell.nix

@marsam marsam merged commit e86f68f into NixOS:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tfmoraes @marsam