Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscodium: 1.49.3 -> 1.50.0 #100117

Merged
merged 1 commit into from Oct 14, 2020
Merged

vscodium: 1.49.3 -> 1.50.0 #100117

merged 1 commit into from Oct 14, 2020

Conversation

samuela
Copy link
Member

@samuela samuela commented Oct 10, 2020

Motivation for this change

Upgrades vscodium from 1.49.3 to 1.50.0

This PR was automatically generated by nixpkgs-upkeep.

  • CI workflow that created this PR.
  • Internal tag: fb7ac01bc4c48d72b4a819eef4a5fff2.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Synthetica9 October 10, 2020 00:30
danieldk
danieldk approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Result of nixpkgs-review pr 100117 1

1 package built:
  • vscodium

codium confirmed to work.

@danieldk danieldk merged commit 625a48c into NixOS:master Oct 14, 2020
@samuela samuela deleted the upkeep-bot/vscodium-1.50.0-1602289209 branch October 14, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuela @danieldk