Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3packages.sip: 4.19.24 -> 5.5.0.dev2010041444 #100129

Closed
wants to merge 2 commits into from
Closed

python3packages.sip: 4.19.24 -> 5.5.0.dev2010041444 #100129

wants to merge 2 commits into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 10, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh mentioned this pull request Oct 10, 2020
Closed
10 tasks
FRidh
FRidh commented Oct 10, 2020
View reviewed changes
pkgs/development/python-modules/sip/default.nix
, packaging
, toml
, pythonOlder
, python
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused python

@FRidh
Copy link
Member Author

FRidh commented Oct 10, 2020

The pyqt5 configure and build instructions are not really up to date. They say

Prior to the release of SIP v5 the only way to build PyQt5 (and related projects) was based on a configure.py script. This method is now deprecated and will be removed when SIP v6 is released (which is expected to be mid-2020).

however, don't offer any other method (the configuration file needs to be passed to configure.py.

@ofborg ofborg bot requested a review from svanderburg October 10, 2020 07:48
@FRidh FRidh mentioned this pull request Oct 13, 2020
Closed
@FRidh FRidh added this to the 21.03 milestone Nov 12, 2020
@ento ento mentioned this pull request Dec 30, 2020
Merged
10 tasks
@eduardosm
Copy link
Contributor

@FRidh What's the state of this?

sip5 is required to build calibre5. You can check this branch, where sip5 is added as new package, while sip stays at version 4, and calibre5 builds successfully.

cc @ento

@FRidh
Copy link
Member Author

FRidh commented Dec 31, 2020 •
edited

SIp 5 indeed seems much simpler to install. pyqt5 however also needs to be upgraded.

You can check this branch, where sip5 is added as new package, while sip stays at version 4, and calibre5 builds successfully.

We cannot have multiple versions of sip in python-packages.nix, because it may cause conflicts. It is however fine if the sip 5 package for now is private to calibre.

@eduardosm
Copy link
Contributor

We cannot have multiple versions of sip in python-packages.nix, because it may cause conflicts.

Is that true? It looks like at least Arch, Debian and Fedora includes both, which makes me think that sip5 is not backwards compatible with sip4 (can be checked quickly at https://pkgs.org/).

It is however fine if the sip 5 package for now is private to calibre.

How would that be made? Note that calibre also needs pyqt5 to use sip5.

@FRidh
Copy link
Member Author

FRidh commented Dec 31, 2020

How would that be made? Note that calibre also needs pyqt5 to use sip5.

Ah, ok. Yes, we really need to get that working then. Maybe the pyqt5 build is actually simpler now as well, I just started off with the old one to ensure we did not lose anything. If the tarballs on PyPI and riverbank site are the same, then that's good.

@eduardosm
Copy link
Contributor

I have created #108041, where sip5 is added as an additional package. Right now I'm running some nixpkgs-review iterations.

@mexisme
Copy link

mexisme commented Jan 2, 2021

We cannot have multiple versions of sip in python-packages.nix, because it may cause conflicts.

Is that true? It looks like at least Arch, Debian and Fedora includes both, which makes me think that sip5 is not backwards compatible with sip4 (can be checked quickly at https://pkgs.org/).

Does it matter that sip4 is no longer supported by upstream?
I feel like an unsupported version should not be the default, though.

@sbourdeauducq
Copy link
Contributor

See also: #74974 (comment)

@siraben siraben closed this Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
21.05
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@FRidh @eduardosm @mexisme @sbourdeauducq @siraben