Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] unbound: 1.11.0 -> 1.12.0 #100058

Merged
merged 1 commit into from Oct 18, 2020
Merged

[staging] unbound: 1.11.0 -> 1.12.0 #100058

merged 1 commit into from Oct 18, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 8, 2020

Motivation for this change

New upstream release
https://www.nlnetlabs.nl/news/2020/Oct/08/unbound-1.12.0-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"We" might want to consider

The DoH is enabled when Unbound is compiled with the nghttp2 library, with configure --with-libnghttp2.

but that can be done anytime later.

I believe DoT protocol is much better, but on many clients there's no such choice.

@vcunat vcunat merged commit a6d8c4f into NixOS:staging Oct 18, 2020
@mweinelt mweinelt deleted the unbound branch October 18, 2020 11:54
@dotlambda
Copy link
Member

This should have been backported: #110673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants