Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maestral-gui: 1.2.0 -> 1.2.1 #100059

Merged
merged 2 commits into from Oct 9, 2020
Merged

maestral-gui: 1.2.0 -> 1.2.1 #100059

merged 2 commits into from Oct 9, 2020

Conversation

SFrijters
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Also match the dependencies with the dependencies in setup.py again.
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
gui opens fine
cli shows usage

https://github.com/NixOS/nixpkgs/pull/100059
3 packages built:
maestral maestral-gui python37Packages.maestral

@jonringer jonringer merged commit cd0065d into NixOS:master Oct 9, 2020
@SFrijters SFrijters deleted the maestral-1.2.1 branch October 18, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants