[20.09] git-mediate: enable Hydra build again #102491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-mediate was unbroke in e5aef98 but I forgot to enable the Hydra build again by removing the hydraPlatforms line. Fixing my faux pas with this commit. Additional I am removing the setting of broke to false, since false seems to be anyhow the default.
10 tasks
|
I suppose this should be equivalent to re-running hackage2nix. KaiHa has already changed the yaml file. |
cdepillabout
approved these changes
Nov 3, 2020
There was a problem hiding this comment.
@KaiHa Thanks for following up on this, this looks good.
@roberth We don't actually re-run the hackage update script on the release branches, but instead just manually edit the hackage-packages.nix file. (However, we do try to add things to the configuration-hackage2nix.nix file so that if the hackage-packages.nix file were to be regenerated, it would be regenerated correctly.)
|
It looks like ofborg isn't evaluating correctly, but I don't think that is related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git-mediate was unbroke in e5aef98
but I forgot to enable the Hydra build again by removing the
hydraPlatforms line. Fixing my faux pas with this commit.
Additional I am removing the setting of broke to false, since false
seems to be anyhow the default.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)