Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc9: apply gcc PR 96796 to avoid cycling on certain subreg reloads #102518

Merged
merged 1 commit into from Nov 29, 2020
Merged

gcc9: apply gcc PR 96796 to avoid cycling on certain subreg reloads #102518

merged 1 commit into from Nov 29, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Nov 2, 2020 •
edited

Motivation for this change

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96796

This may have caused the AArch64 build failure of PyTorch in:

#101917

Not sure if this is worth it, or if it's better to wait until a future release to carry this patch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk changed the title Gcc9 avoid cycling gcc9: apply gcc PR 96796 to avoid cycling on certain subreg reloads Nov 2, 2020
@ofborg ofborg bot requested a review from Synthetica9 November 2, 2020 20:20
@r-burns
Copy link
Contributor

r-burns commented Nov 2, 2020

Maybe a dumb question, but is this needed too early in the bootstrap sequence to use fetchpatch on https://gcc.gnu.org/git/?p=gcc.git;a=patch;h=6001db79c477b03eacc7e7049560921fb54b7845

@danieldk danieldk marked this pull request as ready for review November 3, 2020 08:32
@danieldk
Copy link
Contributor Author

danieldk commented Nov 3, 2020

Maybe a dumb question, but is this needed too early in the bootstrap sequence to use fetchpatch on https://gcc.gnu.org/git/?p=gcc.git;a=patch;h=6001db79c477b03eacc7e7049560921fb54b7845

No, unfortunately that doesn't work. Also see the earlier comment in the derivation (which is too far up to see in the GitHub changes view).

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/366

vcunat
vcunat approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pushed upstream (equivalent commit)
  • gcc seems to work

@vcunat vcunat merged commit 1787b2d into NixOS:staging Nov 29, 2020
@danieldk danieldk mentioned this pull request Dec 3, 2020
Merged
10 tasks
@danieldk danieldk deleted the gcc9-avoid-cycling branch December 3, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danieldk @r-burns @nixos-discourse @vcunat