Closes #220 Latest stable is now the default channel #221
Conversation
src/Search.elm
Outdated
| -- Concentrates logic near releases definition. | ||
| -- Otherwise you would have remember to modify @:124 defaultChannel each time. | ||
| -- Bump when new channel is released. | ||
| latest_stable : String | ||
| latest_stable = "20.09" |
There was a problem hiding this comment.
I think we should do this more programmatically. It would be more work but also require less maintenance.
src/Search.elm
Outdated
| -- Otherwise you would have remember to modify @:124 defaultChannel each time. | ||
| -- Bump when new channel is released. | ||
| latest_stable : String | ||
| latest_stable = "20.09" |
There was a problem hiding this comment.
lets rename this into defaultChannel, but it would be actually nice to change how we handle channels in a way that we wouldn't have to update this every time the release is made.
There was a problem hiding this comment.
I agree. Though I'm not against merging this PR as first step and then continuing with more future proofed solution in new PR.
There was a problem hiding this comment.
We could fetch active channels via the metrics, like status.nixos.org already does it (https://github.com/NixOS/nixos-org-configurations/blob/master/delft/eris/status-page/status.js#L102) and then pass this list of string down (flake.nix -> src/index.js -> src/Search.elm)
There was a problem hiding this comment.
defaultChannel is already defined on line 121 for the request model unfortunately.
You are both 100% right that it should not be a manual update in the code. I view default channel issue and the automatic channel fetching as two separates enhancements, so if you agree I would:
- Create a separate issue for the channel fetching. {Someone} can then work on it. I am very much a novice in Elm but I wouldn't mind trying :)
- Rename
latest_stabletodefaultChannelStableor anything else to your liking that will not conflict with existing code.
There was a problem hiding this comment.
I renamed the latest_stable to defaultChannel and merge the PR since it is a step forward.
If you would like to work on this I can offer help to mentor you. The task will require a bit more then just Elm. Here is how things should be done (in order):
- create
./update.shwhere we will fetch active channels (like status.nixos.org) and store then in./channels.json - add update step to cron workflow (
.github/workflows/cron.yml). we also need to commit back the changes like we do in nixos-homepage - in
default.nixreadchannels.jsonand pass make it available in the dev/build environment via variable like we already do this forELASTICSEARCH_MAPPING_SCHEMA_VERSION. - in
src/index.jswe would use just passed variable as a initialization flag, like we already do forELASTICSEARCH_MAPPING_SCHEMA_VERSION. - we would extend Flags alias type in
src/Main.elmand pass it down tosrc/Search.elm
latest_stablepointing to the latest stable channel near channels definition. (Line 293)defaultChannelwhen unspecified.This is imho better than only changing the line
Maybe.withDefault "unstable"toMaybe.withDefault "20.09", because if done this way we would have to change version numbers at two places (Line 124 and the definitions around Line 280)