Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmpk: 0.5.1 -> 0.7.2 #102521

Merged
merged 2 commits into from Nov 12, 2020
Merged

vmpk: 0.5.1 -> 0.7.2 #102521

merged 2 commits into from Nov 12, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 2, 2020 •
edited

Also migrate from qt4 to qt5 (#33248)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/272

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102521 run on x86_64-linux 1

1 package built:
  • vmpk

@jonringer
Copy link
Contributor

I'm assuming I need some service or hardware to use this?

[nix-shell:/home/jon/.cache/nixpkgs-review/pr-102521]$ ./results/vmpk/bin/vmpk
Failure loading Qt5 translations for "en_US" from "/nix/store/dw26fwjr4lgwig2daikfagrpw4w2x8y5-qtbase-5.15.0/translations"
Failure loading VMPK translations for "en_US" from "/nix/store/g45ww56yrw0qjg2vrb764050hh6bdiyd-vmpk-0.7.2/bin/../share/vmpk/locale/"
Default MIDI IN driver "Network" not found
Default MIDI OUT driver "SonivoxEAS" not found
Unable to initialize all MIDI drivers. Terminating.

@freezeboy
Copy link
Contributor Author

I guess also I had the same output but I don't have any midi hardware

@jonringer
Copy link
Contributor

cc @orivej

orivej
orivej suggested changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vmpk does not need MIDI hardware, it only needs ALSA MIDI sequencer. (If aplaymidi -l does not give an error it should work. The old vmpk should work as well.)

vmpk 0.7.2 seems to require drumstick with libpulseaudio — otherwise drumstick does not ship libdrumstick-rt-eassynth.so — but even with this plugin installed drumstick seems unable to find it. This requires further investigation…

pkgs/applications/audio/vmpk/default.nix Outdated

buildInputs = [ alsaLib libjack2 qt4 ];
buildInputs = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore CMake/pkg-config warnings and do not add static dependencies to buildInputs. (Issue report.) This seems OK:

nativeBuildInputs = [ cmake docbook-xsl-nons pkg-config qttools ];
buildInputs = [ drumstick qtx11extras ];

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@orivej
Copy link
Contributor

orivej commented Nov 11, 2020

Thanks!

Drumstick plugins dir is supposed to be added to the search path here. I have not checked why it does not work, but I've noticed a workaround above — executable-relative lookup. To exploit it, add ln -s ${drumstick}/lib $out to vmpk postInstall (and add libpulseaudio to drumstick buildInputs).

@ofborg ofborg bot requested a review from solson November 11, 2020 17:18
orivej
orivej approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

orivej and others added 2 commits November 12, 2020 03:41
@orivej
drumstick: fix plugin lookup and enable SonivoxEAS and FluidSynth plu…
a1c9c43 
…gins

SonivoxEAS is enabled by building with PulseAudio.
@freezeboy @orivej
vmpk: 0.5.1 -> 0.7.2
fd9f28c 
Also migrate from qt4 to qt5 (NixOS#33248)
@orivej
Copy link
Contributor

orivej commented Nov 12, 2020

I've decided to patch drumstick to fix plugin lookup.

@orivej-nixos orivej-nixos merged commit df89889 into NixOS:master Nov 12, 2020
@freezeboy freezeboy deleted the update-vmpk branch November 12, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

@solson solson Awaiting requested review from solson

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@freezeboy @nixos-discourse @SuperSandro2000 @jonringer @orivej @orivej-nixos