Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdesktopenv: fix build w/glibc-2.32 #102495

Merged
merged 1 commit into from Nov 8, 2020
Merged

cdesktopenv: fix build w/glibc-2.32 #102495

merged 1 commit into from Nov 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 2, 2020 •
edited by ghost

Motivation for this change

After #95089
Upstream provided patch which worked nicely https://sourceforge.net/p/cdesktopenv/code/ci/67f62e5a8acd70d30f7067f1f44ac7b15c67011a/
Tested for build and also execution

cc @Ma27

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Nov 8, 2020

ping @Ma27

@Ma27 Ma27 merged commit 06383b5 into NixOS:master Nov 8, 2020
@ghost
Copy link
Author

ghost commented Nov 8, 2020

@Ma27 Thank you!

@ghost ghost deleted the cde2 branch November 8, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Ma27