Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openxray: 730-july-preview -> 784-october-preview #102511

Merged
merged 1 commit into from Nov 4, 2020
Merged

openxray: 730-july-preview -> 784-october-preview #102511

merged 1 commit into from Nov 4, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 2, 2020 •
edited by ghost

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost changed the title Openxray openxray: 730-july-preview -> 784-october-preview Nov 2, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/355

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102511 run on x86_64-linux 1

1 package built:
  • openxray

@FRidh FRidh merged commit c2bd0a4 into NixOS:master Nov 4, 2020
@ghost
Copy link
Author

ghost commented Nov 4, 2020 •
edited by ghost

@FRidh @SuperSandro2000 thank you!

@ghost ghost deleted the openxray branch November 4, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nixos-discourse @SuperSandro2000 @FRidh